github-vet / github-vet/rangeloop-pointer-findings

yingyan003/netChecker: src/vendor/k8s.io/kubernetes/pkg/controller/node/controller_utils.go; 22 LoC

Open
#6,481 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [yingyan003/netChecker](https://www.github.com/yingyan003/netChecker) at [src/vendor/k8s.io/kubernetes/pkg/controller/node/controller_utils.go](https://github.com/yingyan003/netChecker/blob/32661fc5ba586d9bdc17a756f570d45954caa996/src/vendor/k8s.io/kubernetes/pkg/controller/node/controller_utils.go#L99-L120)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call which takes a reference to pod at line 115 may start a goroutine

[Click here to see the code in its original context.](https://github.com/yingyan003/netChecker/blob/32661fc5ba586d9bdc17a756f570d45954caa996/src/vendor/k8s.io/kubernetes/pkg/controller/node/controller_utils.go#L99-L120)

Click here to show the 22 line(s) of Go which triggered the analyzer.

```go
for _, pod := range pods.Items {
// Defensive check, also needed for tests.
if pod.Spec.NodeName != nodeName {
continue
}
// if the pod has already been deleted, ignore it
if pod.DeletionGracePeriodSeconds != nil {
continue
}
// if the pod is managed by a daemonset, ignore it
_, err := daemonStore.GetPodDaemonSets(&pod)
if err == nil { // No error means at least one daemonset was found
continue
}

glog.V(2).Infof("Starting deletion of pod %v", pod.Name)
recorder.Eventf(&pod, api.EventTypeNormal, "NodeControllerEviction", "Marking for deletion Pod %s from Node %s", pod.Name, nodeName)
if err := kubeClient.Core().Pods(pod.Namespace).Delete(pod.Name, nil); err != nil {
return false, err
}
remaining = true
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 32661fc5ba586d9bdc17a756f570d45954caa996

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.