github-vet / github-vet/rangeloop-pointer-findings

CJey/sudu: task_group.go; 39 LoC

Open
#6,379 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [CJey/sudu](https://www.github.com/CJey/sudu) at [task_group.go](https://github.com/CJey/sudu/blob/ab8f9c52e3b42aaea6731c3276ff7a07219e8f69/task_group.go#L40-L78)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable fx used in defer or goroutine at line 76

[Click here to see the code in its original context.](https://github.com/CJey/sudu/blob/ab8f9c52e3b42aaea6731c3276ff7a07219e8f69/task_group.go#L40-L78)

Click here to show the 39 line(s) of Go which triggered the analyzer.

```go
for _, fx := range fxs {
wg.Add(1)
go func() {
defer func() {
tg.fx_lock.Lock()
defer tg.fx_lock.Unlock()

tg.Running--

if tg.fx_panic == nil || tg.WaitAll {
tg.wg.Done()
}

if p := recover(); p != nil && tg.fx_panic == nil {
if tg.panicFilter != nil {
p = tg.panicFilter(p)
}
if p != nil {
tg.fx_panic = p
if !tg.WaitAll {
tg.wg.Add(tg.Running * -1)
}
}
}
}()

tg.fx_lock.Lock()
if tg.fx_panic == nil || tg.WaitAll {
tg.wg.Add(1)
}
tg.fx_lock.Unlock()

tg.Tasks++
tg.Running++
wg.Done()

fx()
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: ab8f9c52e3b42aaea6731c3276ff7a07219e8f69

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.