github-vet / github-vet/rangeloop-pointer-findings
hlandauf/btcnode: mempool.go; 10 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [hlandauf/btcnode](https://www.github.com/hlandauf/btcnode) at [mempool.go](https://github.com/hlandauf/btcnode/blob/e141647cdc2a8b8d013905b58d8ab06280c10d4f/mempool.go#L477-L486)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to txHash is reassigned at line 479
[Click here to see the code in its original context.](https://github.com/hlandauf/btcnode/blob/e141647cdc2a8b8d013905b58d8ab06280c10d4f/mempool.go#L477-L486)
Click here to show the 10 line(s) of Go which triggered the analyzer.
```go
for txHash := range mp.orphans {
if foundHash == nil {
foundHash = &txHash
}
txHashNum := btcchain.ShaHashToBig(&txHash)
if txHashNum.Cmp(randHashNum) > 0 {
foundHash = &txHash
break
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: e141647cdc2a8b8d013905b58d8ab06280c10d4f
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.