github-vet / github-vet/rangeloop-pointer-findings

monsti/monsti: core/monsti-daemon/service.go; 21 LoC

Open
#6,362 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [monsti/monsti](https://www.github.com/monsti/monsti) at [core/monsti-daemon/service.go](https://github.com/monsti/monsti/blob/78ecff227f520fb2169bbcc90bb73c8f6b95e7f8/core/monsti-daemon/service.go#L170-L190)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable id used in defer or goroutine at line 179

[Click here to see the code in its original context.](https://github.com/monsti/monsti/blob/78ecff227f520fb2169bbcc90bb73c8f6b95e7f8/core/monsti-daemon/service.go#L170-L190)

Click here to show the 21 line(s) of Go which triggered the analyzer.

```go
for i, id := range m.subscriptions[args.Name] {
retChan := make(chan emitRet)
done := false
go func() {
time.Sleep(time.Second)
for !done {
time.Sleep(30 * time.Second)
m.Logger.Printf(
"Waiting for signal response. Signal: %v, Subscriber: %v",
args.Name, id)
}
}()
m.subscriber[id] <- &signal{args.Name, args.Args, retChan}
emitRet := <-retChan
if len(emitRet.Error) > 0 {
done = true
return fmt.Errorf("Received error as signal response: %v", emitRet.Error)
}
(*ret)[i] = emitRet.Ret
done = true
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 78ecff227f520fb2169bbcc90bb73c8f6b95e7f8

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.