github-vet / github-vet/rangeloop-pointer-findings
soteria-dag/soterdash: models.go; 14 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [soteria-dag/soterdash](https://www.github.com/soteria-dag/soterdash) at [models.go](https://github.com/soteria-dag/soterdash/blob/80bd5bbc8f5babdaeaa92e45c1f51b11ffc72d3d/models.go#L73-L86)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to p is reassigned at line 85
[Click here to see the code in its original context.](https://github.com/soteria-dag/soterdash/blob/80bd5bbc8f5babdaeaa92e45c1f51b11ffc72d3d/models.go#L73-L86)
Click here to show the 14 line(s) of Go which triggered the analyzer.
```go
for _, p := range peers {
var targetMap *map[int32]*soterjson.GetPeerInfoResult
if p.Inbound {
targetMap = &inbound
} else {
targetMap = &outbound
}
_, exists := (*targetMap)[p.ID]
if exists {
continue
}
(*targetMap)[p.ID] = &p
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 80bd5bbc8f5babdaeaa92e45c1f51b11ffc72d3d
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.