github-vet / github-vet/rangeloop-pointer-findings

yjq-owner/bk-cmdb: src/source_controller/coreservice/core/model/classification.go; 33 LoC

Open
#6,233 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [yjq-owner/bk-cmdb](https://www.github.com/yjq-owner/bk-cmdb) at [src/source_controller/coreservice/core/model/classification.go](https://github.com/yjq-owner/bk-cmdb/blob/011400903fb92cf1c444ea32a6196ae4c457ee37/src/source_controller/coreservice/core/model/classification.go#L78-L110)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call which takes a reference to item at line 82 may start a goroutine

[Click here to see the code in its original context.](https://github.com/yjq-owner/bk-cmdb/blob/011400903fb92cf1c444ea32a6196ae4c457ee37/src/source_controller/coreservice/core/model/classification.go#L78-L110)

Click here to show the 33 line(s) of Go which triggered the analyzer.

```go
for itemIdx, item := range inputParam.Data {

if 0 == len(item.ClassificationID) {
blog.Errorf("request(%s): it is failed to create the model classification, because of the classificationID (%#v) is not set", ctx.ReqID, item.ClassificationID)
addExceptionFunc(int64(itemIdx), ctx.Error.Errorf(common.CCErrCommParamsNeedSet, metadata.ClassFieldClassificationID).(errors.CCErrorCoder), &item)
continue
}

_, exists, err := m.isExists(ctx, item.ClassificationID, item.Metadata)
if nil != err {
blog.Errorf("request(%s): it is failed to check the classification ID (%s) is exists, error info is %s", ctx.ReqID, item.ClassificationID, err.Error())
addExceptionFunc(int64(itemIdx), err.(errors.CCErrorCoder), &item)
continue
}

if exists {
dataResult.Repeated = append(dataResult.Repeated, metadata.RepeatedDataResult{OriginIndex: int64(itemIdx), Data: mapstr.NewFromStruct(item, "field")})
continue
}

item.OwnerID = ctx.SupplierAccount
id, err := m.save(ctx, item)
if nil != err {
blog.Errorf("request(%s): it is failed to save the classification(%#v), error info is %s", ctx.ReqID, item, err.Error())
addExceptionFunc(int64(itemIdx), err.(errors.CCErrorCoder), &item)
continue
}

dataResult.Created = append(dataResult.Created, metadata.CreatedDataResult{
ID: id,
})

}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 011400903fb92cf1c444ea32a6196ae4c457ee37

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.