github-vet / github-vet/rangeloop-pointer-findings
NEU-SNS/ReverseTraceroutePublic: controller/controller.go; 14 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [NEU-SNS/ReverseTraceroutePublic](https://www.github.com/NEU-SNS/ReverseTraceroutePublic) at [controller/controller.go](https://github.com/NEU-SNS/ReverseTraceroutePublic/blob/d0596d9f6bd6687e99246ce03b5e27719683fa5b/controller/controller.go#L345-L358)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable key used in defer or goroutine at line 349
[Click here to see the code in its original context.](https://github.com/NEU-SNS/ReverseTraceroutePublic/blob/d0596d9f6bd6687e99246ce03b5e27719683fa5b/controller/controller.go#L345-L358)
Click here to show the 14 line(s) of Go which triggered the analyzer.
```go
for key, val := range checkDb {
if p, ok := dbs[key]; ok {
//This should be stored in the cache
go func() {
var err = c.cache.SetWithExpire(key, p.CMarshal(), 5*60)
if err != nil {
log.Info(err)
}
}()
ret <- p
} else {
remaining = append(remaining, val)
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: d0596d9f6bd6687e99246ce03b5e27719683fa5b
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.