github-vet / github-vet/rangeloop-pointer-findings

Lukasdeloose/decentralized-voting-system: project/rumorer/rumorer.go; 47 LoC

Open
#6,211 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Lukasdeloose/decentralized-voting-system](https://www.github.com/Lukasdeloose/decentralized-voting-system) at [project/rumorer/rumorer.go](https://github.com/Lukasdeloose/decentralized-voting-system/blob/3e9230c63c2393d46259bb4f50ebbcfec4080607/project/rumorer/rumorer.go#L105-L151)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable packet used in defer or goroutine at line 107

[Click here to see the code in its original context.](https://github.com/Lukasdeloose/decentralized-voting-system/blob/3e9230c63c2393d46259bb4f50ebbcfec4080607/project/rumorer/rumorer.go#L105-L151)

Click here to show the 47 line(s) of Go which triggered the analyzer.

```go
for packet := range r.in {
go func() {
gossip := packet.Gossip
address := packet.Address

// Dispatch packet according to type
mongerableMsg := gossip.ToMongerableMessage()

if mongerableMsg != nil {
// Expand peers list
if address.String() != "" {
r.peers.Add(address)
} else {
// The message is ours: if it does not have an ID yet: give it one
if mongerableMsg.GetID() == 0 {
r.idMutex.Lock()
mongerableMsg.SetID(r.id)
r.id += 1
r.idMutex.Unlock()
}
}

if gossip.Rumor != nil {
// Print logging info
r.printRumor(gossip.Rumor, address)
} else if gossip.Transaction != nil {
r.printTx(gossip.Transaction)
} else if gossip.MongerableBlock != nil {
r.printBlock(gossip.MongerableBlock)
}

// Handle the message
r.handleRumor(mongerableMsg, address, false)

} else if gossip.Status != nil {
// Expand peers list
r.peers.Add(address)

// Print logging info
r.printStatus(gossip.Status, address)

// Handle the message
r.handleStatus(gossip.Status, address)

} // Ignore SimpleMessage
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 3e9230c63c2393d46259bb4f50ebbcfec4080607

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.