github-vet / github-vet/rangeloop-pointer-findings

sudhamisha/vmw-kube: pkg/controller/node/nodecontroller.go; 17 LoC

Open
#6,156 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [sudhamisha/vmw-kube](https://www.github.com/sudhamisha/vmw-kube) at [pkg/controller/node/nodecontroller.go](https://github.com/sudhamisha/vmw-kube/blob/09869715fc1f74f7ddcd6a3da45cfbacd4715896/pkg/controller/node/nodecontroller.go#L594-L610)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call which takes a reference to pod at line 605 may start a goroutine

[Click here to see the code in its original context.](https://github.com/sudhamisha/vmw-kube/blob/09869715fc1f74f7ddcd6a3da45cfbacd4715896/pkg/controller/node/nodecontroller.go#L594-L610)

Click here to show the 17 line(s) of Go which triggered the analyzer.

```go
for _, pod := range pods.Items {
// Defensive check, also needed for tests.
if pod.Spec.NodeName != nodeName {
continue
}
// if the pod has already been deleted, ignore it
if pod.DeletionGracePeriodSeconds != nil {
continue
}

glog.V(2).Infof("Delete pod %v", pod.Name)
nc.recorder.Eventf(&pod, "NodeControllerEviction", "Deleting Pod %s from Node %s", pod.Name, nodeName)
if err := nc.kubeClient.Pods(pod.Namespace).Delete(pod.Name, nil); err != nil {
return false, err
}
remaining = true
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 09869715fc1f74f7ddcd6a3da45cfbacd4715896

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.