github-vet / github-vet/rangeloop-pointer-findings

develersrl/lunches: pkg/tinabot/mark.go; 14 LoC

Open
#6,024 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [develersrl/lunches](https://www.github.com/develersrl/lunches) at [pkg/tinabot/mark.go](https://github.com/develersrl/lunches/blob/b6e1816ba827efe89d10d7b3f5e648ec60efa923/pkg/tinabot/mark.go#L70-L83)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable f used in defer or goroutine at line 74

[Click here to see the code in its original context.](https://github.com/develersrl/lunches/blob/b6e1816ba827efe89d10d7b3f5e648ec60efa923/pkg/tinabot/mark.go#L70-L83)

Click here to show the 14 line(s) of Go which triggered the analyzer.

```go
for _, f := range validFood {
if strings.ToUpper(f) == strings.ToUpper(food) {
// This can be slow so spawn a goroutine to give Slack a fast reply and avoid retrys
go func() {
err := MarkUser(user, f)
if err != nil {
t.bot.Message(msg.Channel, "errore: "+err.Error())
return
}
t.bot.Message(msg.Channel, fmt.Sprintf("Ok, segnato '%s' per %s sul foglio dei pranzi", f, user.Name))
}()
return
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: b6e1816ba827efe89d10d7b3f5e648ec60efa923

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.