github-vet / github-vet/rangeloop-pointer-findings

davefinster/docker-machine-driver-triton: driver.go; 8 LoC

Open
#5,971 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [davefinster/docker-machine-driver-triton](https://www.github.com/davefinster/docker-machine-driver-triton) at [driver.go](https://github.com/davefinster/docker-machine-driver-triton/blob/53c7013edc69d5e6ba455227d36dcfbd20a50580/driver.go#L207-L214)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to m is reassigned at line 210

[Click here to see the code in its original context.](https://github.com/davefinster/docker-machine-driver-triton/blob/53c7013edc69d5e6ba455227d36dcfbd20a50580/driver.go#L207-L214)

Click here to show the 8 line(s) of Go which triggered the analyzer.

```go
for _, m := range machines {
log.Debugf("Checking machine with name", m.Name, "compared with", d.MachineName)
if (m.Name == d.MachineName) {
machine = &m
hasMachine = true
log.Debugf("Found machine that was meant to be created")
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 53c7013edc69d5e6ba455227d36dcfbd20a50580

Contributor guide

No contributing guide indexed for this repository

Research direction

Read driver.go at lines 207-214 and inspect how the range variable m is referenced after the analyzer warning. Compare that behavior with the driver's intended machine lookup, then determine whether the finding is a Bug, Mitigated, or Desirable Behavior. Record the classification with the requested reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devops, infrastructure
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.