github-vet / github-vet/rangeloop-pointer-findings

twoshark/lumberjack: errors.go; 15 LoC

Open
#5,967 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [twoshark/lumberjack](https://www.github.com/twoshark/lumberjack) at [errors.go](https://github.com/twoshark/lumberjack/blob/83a252db25012a77b9e46d67b7fc2d018f221d8e/errors.go#L40-L54)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call at line 45 may store a reference to notGoodThing

[Click here to see the code in its original context.](https://github.com/twoshark/lumberjack/blob/83a252db25012a77b9e46d67b7fc2d018f221d8e/errors.go#L40-L54)

Click here to show the 15 line(s) of Go which triggered the analyzer.

```go
for _, notGoodThing := range notGoodThings {
//Add Runtime details
notGoodThing.CreateDate = time.Now()
notGoodThing.Caller = GetCaller()
//Insert pointer to completed error into the error log
e.insert(¬GoodThing)
json, err := StringJSON(notGoodThing)
if err != nil {
warning := WarningJSONParse
warning.ErrorObj = notGoodThing
e.insert(warning)
return
}
log.Println(json)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 83a252db25012a77b9e46d67b7fc2d018f221d8e

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.