github-vet / github-vet/rangeloop-pointer-findings

rdallman/iron-maiden: runner.go; 19 LoC

Open
#5,953 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [rdallman/iron-maiden](https://www.github.com/rdallman/iron-maiden) at [runner.go](https://github.com/rdallman/iron-maiden/blob/c03b5885f0cb39a8dc1468147edc3f53450b31a2/runner.go#L96-L114)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable mq used in defer or goroutine at line 106

[Click here to see the code in its original context.](https://github.com/rdallman/iron-maiden/blob/c03b5885f0cb39a8dc1468147edc3f53450b31a2/runner.go#L96-L114)

Click here to show the 19 line(s) of Go which triggered the analyzer.

```go
for _, mq := range mqs {
fmt.Println(mq.Name()+":", "concurrency benchmark with", messages, "message(s),",
atATime, "at a time, across", queues, "queue(s) using ", bytes, "bytes")

mq.setupQueues(qnames)
var wait sync.WaitGroup
wait.Add(2)
then := time.Now()
go func() {
defer wait.Done()
produce(mq, messages, atATime, threadperQ, qnames, bytes)
}()
go func() {
defer wait.Done()
consume(mq, messages, atATime, threadperQ, qnames)
}()
wait.Wait()
fmt.Println("producer and consumer took", time.Since(then))
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c03b5885f0cb39a8dc1468147edc3f53450b31a2

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.