github-vet / github-vet/rangeloop-pointer-findings

activecm/rita-blacklist: blacklist.go; 39 LoC

Open
#5,952 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [activecm/rita-blacklist](https://www.github.com/activecm/rita-blacklist) at [blacklist.go](https://github.com/activecm/rita-blacklist/blob/c08393ca706f4687517ce11cf0b2c5499ff7230a/blacklist.go#L37-L75)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable val used in defer or goroutine at line 58

[Click here to see the code in its original context.](https://github.com/activecm/rita-blacklist/blob/c08393ca706f4687517ce11cf0b2c5499ff7230a/blacklist.go#L37-L75)

Click here to show the 39 line(s) of Go which triggered the analyzer.

```go
for _, val := range b.Sources {

// Get meta data about this source
sourceInfo, _ := b.Db.GetMetaData(val, dbname)

// Ensure the source is still valid
if !val.ValidList(sourceInfo) {

log.Println("Updating blacklist source: ", val.Name(), ". This may take a few minutes...")

// Remove all host entries from this source
b.Db.RemoveHostList(val, dbname)
b.Db.RegisterHostList(val, dbname)

// Chanel for populating database with new hosts.
c := make(chan datatypes.BlacklistHost)

// Ask this source for an updated list of hosts.
var wg1 sync.WaitGroup
wg1.Add(1)
go func() {
val.UpdateList(c)
wg1.Done()
}()

// Insert hosts from the current source into the database.
var wg2 sync.WaitGroup
wg2.Add(1)
go func() {
b.Db.InsertHosts(c, dbname)
wg2.Done()
}()

// Wait for everything to finish.
wg1.Wait()
close(c)
wg2.Wait()
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c08393ca706f4687517ce11cf0b2c5499ff7230a

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.