github-vet / github-vet/rangeloop-pointer-findings
bydmm/bydmm-yuanlimm-go: cron/rank.go; 14 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [bydmm/bydmm-yuanlimm-go](https://www.github.com/bydmm/bydmm-yuanlimm-go) at [cron/rank.go](https://github.com/bydmm/bydmm-yuanlimm-go/blob/d8121eb1b5d0999348086d3d7f395a115c423341/cron/rank.go#L33-L46)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> function call which takes a reference to stock at line 42 may start a goroutine
[Click here to see the code in its original context.](https://github.com/bydmm/bydmm-yuanlimm-go/blob/d8121eb1b5d0999348086d3d7f395a115c423341/cron/rank.go#L33-L46)
Click here to show the 14 line(s) of Go which triggered the analyzer.
```go
for _, stock := range model.Stocks() {
var order model.StockOrder
err := model.DB.
Where("status = ?", model.Padding).
Where("stock_code = ?", stock.Code).
Where("amount > 0").
Order("price DESC").
First(&order).Error
if err == nil {
model.DB.Model(&stock).Update("buy_price", order.Price)
} else {
model.DB.Model(&stock).Update("buy_price", 0)
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: d8121eb1b5d0999348086d3d7f395a115c423341
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.