github-vet / github-vet/rangeloop-pointer-findings
openshift/local-storage-operator: test/e2e/cleanup_hostdirs.go; 20 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [openshift/local-storage-operator](https://www.github.com/openshift/local-storage-operator) at [test/e2e/cleanup_hostdirs.go](https://github.com/openshift/local-storage-operator/blob/950943aee2a5198a15e54124a4f278c1313d5d91/test/e2e/cleanup_hostdirs.go#L65-L84)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.
> function call which takes a reference to cleanupJob at line 83 may start a goroutine
[Click here to see the code in its original context.](https://github.com/openshift/local-storage-operator/blob/950943aee2a5198a15e54124a4f278c1313d5d91/test/e2e/cleanup_hostdirs.go#L65-L84)
Click here to show the 20 line(s) of Go which triggered the analyzer.
```go
for _, cleanupJob := range cleanupJobs {
// waot for job
matcher.Eventually(func() int32 {
job := &batchv1.Job{}
matcher.Eventually(func() error {
return f.Client.Get(
context.TODO(),
types.NamespacedName{
Name: cleanupJob.GetName(),
Namespace: cleanupJob.GetNamespace()},
job,
)
}).ShouldNot(gomega.HaveOccurred())
completions := job.Status.Succeeded
t.Logf("job completions: %d", completions)
return completions
}, time.Minute*2, time.Second*5).Should(gomega.BeNumerically(">=", 1), "waiting cleanup job to complete: %q", cleanupJob.GetName())
eventuallyDelete(t, &cleanupJob, cleanupJob.GetName())
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 950943aee2a5198a15e54124a4f278c1313d5d91
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.