github-vet / github-vet/rangeloop-pointer-findings

kaspernissen/automation_night_demo: coreos-kubernetes/multi-node/aws/vendor/github.com/coreos/coreos-cloudinit/initialize/config.go; 48 LoC

Open
#5,909 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [kaspernissen/automation_night_demo](https://www.github.com/kaspernissen/automation_night_demo) at [coreos-kubernetes/multi-node/aws/vendor/github.com/coreos/coreos-cloudinit/initialize/config.go](https://github.com/kaspernissen/automation_night_demo/blob/7fb1955971933f4a348987ee2d3e0df4587978bb/coreos-kubernetes/multi-node/aws/vendor/github.com/coreos/coreos-cloudinit/initialize/config.go#L53-L100)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call which takes a reference to user at line 59 may start a goroutine

[Click here to see the code in its original context.](https://github.com/kaspernissen/automation_night_demo/blob/7fb1955971933f4a348987ee2d3e0df4587978bb/coreos-kubernetes/multi-node/aws/vendor/github.com/coreos/coreos-cloudinit/initialize/config.go#L53-L100)

Click here to show the 48 line(s) of Go which triggered the analyzer.

```go
for _, user := range cfg.Users {
if user.Name == "" {
log.Printf("User object has no 'name' field, skipping")
continue
}

if system.UserExists(&user) {
log.Printf("User '%s' exists, ignoring creation-time fields", user.Name)
if user.PasswordHash != "" {
log.Printf("Setting '%s' user's password", user.Name)
if err := system.SetUserPassword(user.Name, user.PasswordHash); err != nil {
log.Printf("Failed setting '%s' user's password: %v", user.Name, err)
return err
}
}
} else {
log.Printf("Creating user '%s'", user.Name)
if err := system.CreateUser(&user); err != nil {
log.Printf("Failed creating user '%s': %v", user.Name, err)
return err
}
}

if len(user.SSHAuthorizedKeys) > 0 {
log.Printf("Authorizing %d SSH keys for user '%s'", len(user.SSHAuthorizedKeys), user.Name)
if err := system.AuthorizeSSHKeys(user.Name, env.SSHKeyName(), user.SSHAuthorizedKeys); err != nil {
return err
}
}
if user.SSHImportGithubUser != "" {
log.Printf("Authorizing github user %s SSH keys for CoreOS user '%s'", user.SSHImportGithubUser, user.Name)
if err := SSHImportGithubUser(user.Name, user.SSHImportGithubUser); err != nil {
return err
}
}
for _, u := range user.SSHImportGithubUsers {
log.Printf("Authorizing github user %s SSH keys for CoreOS user '%s'", u, user.Name)
if err := SSHImportGithubUser(user.Name, u); err != nil {
return err
}
}
if user.SSHImportURL != "" {
log.Printf("Authorizing SSH keys for CoreOS user '%s' from '%s'", user.Name, user.SSHImportURL)
if err := SSHImportKeysFromURL(user.Name, user.SSHImportURL); err != nil {
return err
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 7fb1955971933f4a348987ee2d3e0df4587978bb

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.