github-vet / github-vet/rangeloop-pointer-findings

kaspernissen/automation_night_demo: coreos-kubernetes/multi-node/aws/vendor/github.com/dotcloud/docker/server/server.go; 23 LoC

Open
#5,908 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [kaspernissen/automation_night_demo](https://www.github.com/kaspernissen/automation_night_demo) at [coreos-kubernetes/multi-node/aws/vendor/github.com/dotcloud/docker/server/server.go](https://github.com/kaspernissen/automation_night_demo/blob/7fb1955971933f4a348987ee2d3e0df4587978bb/coreos-kubernetes/multi-node/aws/vendor/github.com/dotcloud/docker/server/server.go#L79-L101)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable sig used in defer or goroutine at line 81

[Click here to see the code in its original context.](https://github.com/kaspernissen/automation_night_demo/blob/7fb1955971933f4a348987ee2d3e0df4587978bb/coreos-kubernetes/multi-node/aws/vendor/github.com/dotcloud/docker/server/server.go#L79-L101)

Click here to show the 23 line(s) of Go which triggered the analyzer.

```go
for sig := range c {
go func() {
log.Printf("Received signal '%v', starting shutdown of docker...\n", sig)
switch sig {
case os.Interrupt, syscall.SIGTERM:
// If the user really wants to interrupt, let him do so.
if interruptCount < 3 {
interruptCount++
// Initiate the cleanup only once
if interruptCount == 1 {
utils.RemovePidFile(srv.daemon.Config().Pidfile)
srv.Close()
} else {
return
}
} else {
log.Printf("Force shutdown of docker, interrupting cleanup\n")
}
case syscall.SIGQUIT:
}
os.Exit(128 + int(sig.(syscall.Signal)))
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 7fb1955971933f4a348987ee2d3e0df4587978bb

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.