github-vet / github-vet/rangeloop-pointer-findings

grpc-up-and-running/samples: ch05/error-handling/order-service/go/server/main.go; 4 LoC

Open
#5,874 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [grpc-up-and-running/samples](https://www.github.com/grpc-up-and-running/samples) at [ch05/error-handling/order-service/go/server/main.go](https://github.com/grpc-up-and-running/samples/blob/1f9de1e3efd98182883c93f36ad3a15039fe58f3/ch05/error-handling/order-service/go/server/main.go#L137-L140)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first
issue it finds, so please do not limit your consideration to the contents of the below message.

> function call which takes a reference to comb at line 139 may start a goroutine

[Click here to see the code in its original context.](https://github.com/grpc-up-and-running/samples/blob/1f9de1e3efd98182883c93f36ad3a15039fe58f3/ch05/error-handling/order-service/go/server/main.go#L137-L140)

Click here to show the 4 line(s) of Go which triggered the analyzer.

```go
for _, comb := range combinedShipmentMap {
log.Print("Shipping : ", comb.Id, " -> ", len(comb.OrdersList))
stream.Send(&comb)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 1f9de1e3efd98182883c93f36ad3a15039fe58f3

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.