github-vet / github-vet/rangeloop-pointer-findings
pingcap/octopus: benchbot/backend/job.go; 23 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [pingcap/octopus](https://www.github.com/pingcap/octopus) at [benchbot/backend/job.go](https://github.com/pingcap/octopus/blob/43a2903f19c98d20e7ad4b0f981f35a57c3e3fb4/benchbot/backend/job.go#L125-L147)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable op used in defer or goroutine at line 128
[Click here to see the code in its original context.](https://github.com/pingcap/octopus/blob/43a2903f19c98d20e7ad4b0f981f35a57c3e3fb4/benchbot/backend/job.go#L125-L147)
Click here to show the 23 line(s) of Go which triggered the analyzer.
```go
for step, op := range ops {
res := make(chan error)
go func() {
res <- op()
}()
var err error
select {
case err = <-res:
if err != nil {
log.Errorf("[job-%d] failed to init cluster (step=%d): %s", job.ID, step, err)
}
case <-job.ctx.Done():
log.Infof("[job-%d] receive aborted signal during cluster init", job.ID)
err = fmt.Errorf("[job-%d] aborted", job.ID)
}
if err != nil {
cluster.Close()
return nil, err
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 43a2903f19c98d20e7ad4b0f981f35a57c3e3fb4
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.