github-vet / github-vet/rangeloop-pointer-findings

ovh/lhasa: api/v1/badge/repository.go; 8 LoC

Open
#18,427 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [ovh/lhasa](https://www.github.com/ovh/lhasa) at [api/v1/badge/repository.go](https://github.com/ovh/lhasa/blob/6899a919ec2bb35e34d2178dbb9a2947ba472142/api/v1/badge/repository.go#L140-L147)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to lvl is reassigned at line 145

[Click here to see the code in its original context.](https://github.com/ovh/lhasa/blob/6899a919ec2bb35e34d2178dbb9a2947ba472142/api/v1/badge/repository.go#L140-L147)

Click here to show the 8 line(s) of Go which triggered the analyzer.

```go
for _, lvl := range levels {
if lvl.ID == id {
return &lvl, nil
}
if lvl.IsDefault {
defaultLevel = &lvl
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 6899a919ec2bb35e34d2178dbb9a2947ba472142

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with api/v1/badge/repository.go at the linked lines and read the surrounding function and analyzer context. Check whether the returned pointers to the range variable can produce incorrect behavior, then use the issue's Bug, Mitigated, or Desirable Behavior reactions to record the justified classification.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.