github-vet / github-vet/rangeloop-pointer-findings
ilia-khaustov/NSFWGuard: NSFWGuard/tgbot/ctrl.go; 6 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [ilia-khaustov/NSFWGuard](https://www.github.com/ilia-khaustov/NSFWGuard) at [NSFWGuard/tgbot/ctrl.go](https://github.com/ilia-khaustov/NSFWGuard/blob/6a13e3dd2b69fac4cd87db1944d1b83086e7a5e3/NSFWGuard/tgbot/ctrl.go#L211-L216)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to photo is reassigned at line 214
[Click here to see the code in its original context.](https://github.com/ilia-khaustov/NSFWGuard/blob/6a13e3dd2b69fac4cd87db1944d1b83086e7a5e3/NSFWGuard/tgbot/ctrl.go#L211-L216)
Click here to show the 6 line(s) of Go which triggered the analyzer.
```go
for _, photo := range photos {
if photo.Height*photo.Width >= maxSize {
maxSize = photo.Height * photo.Width
biggest = &photo
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 6a13e3dd2b69fac4cd87db1944d1b83086e7a5e3
Contributor guide
No contributing guide indexed for this repository
Research direction
Read NSFWGuard/tgbot/ctrl.go around lines 211-216 and the analyzer message about the reassigned photo reference. Check the surrounding code to understand how biggest is used and whether the reported range-loop reference affects the intended selection. Done means the finding is classified as Bug, Mitigated, or Desirable Behavior with the corresponding reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100