github-vet / github-vet/rangeloop-pointer-findings

gokitter/kitter: server/server.go; 5 LoC

Open
#18,380 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [gokitter/kitter](https://www.github.com/gokitter/kitter) at [server/server.go](https://github.com/gokitter/kitter/blob/86cadf36a862ce9351eb91716b6ae7802dbfb0fe/server/server.go#L22-L26)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable channel used in defer or goroutine at line 24

[Click here to see the code in its original context.](https://github.com/gokitter/kitter/blob/86cadf36a862ce9351eb91716b6ae7802dbfb0fe/server/server.go#L22-L26)

Click here to show the 5 line(s) of Go which triggered the analyzer.

```go
for _, channel := range b.channels {
go func() {
channel <- message
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 86cadf36a862ce9351eb91716b6ae7802dbfb0fe

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with server/server.go lines 22-26 and inspect how b.channels and message are used around the goroutine. Confirm whether each goroutine targets the intended channel and reproduce the analyzer finding. Done means the reported range-loop capture is resolved and the behavior is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.