github-vet / github-vet/rangeloop-pointer-findings

diamondburned/ningen: md/mention.go; 7 LoC

Open
#18,363 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [diamondburned/ningen](https://www.github.com/diamondburned/ningen) at [md/mention.go](https://github.com/diamondburned/ningen/blob/ce64ffb0bb120b2e535a7ab4c7d394be5fb9cbf7/md/mention.go#L95-L101)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to user is reassigned at line 97

[Click here to see the code in its original context.](https://github.com/diamondburned/ningen/blob/ce64ffb0bb120b2e535a7ab4c7d394be5fb9cbf7/md/mention.go#L95-L101)

Click here to show the 7 line(s) of Go which triggered the analyzer.

```go
for _, user := range msg.Mentions {
if user.ID == d {
target = &user
mentioned = true // user is mentioned
break
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: ce64ffb0bb120b2e535a7ab4c7d394be5fb9cbf7

Contributor guide

No contributing guide indexed for this repository

Research direction

Review md/mention.go at lines 95-101 in diamondburned/ningen and compare the analyzer report with the surrounding range-loop code. Done means determining whether the finding is a Bug, Mitigated, or Desirable Behavior and leaving the corresponding reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.