github-vet / github-vet/rangeloop-pointer-findings

ownode/ownode: controllers/object.go; 30 LoC

Open
#18,312 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [ownode/ownode](https://www.github.com/ownode/ownode) at [controllers/object.go](https://github.com/ownode/ownode/blob/f93870dd35c46c598e25f5f43d495b33b53d3934/controllers/object.go#L358-L387)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/ownode/ownode/blob/f93870dd35c46c598e25f5f43d495b33b53d3934/controllers/object.go#L358-L387)

Click here to show the 30 line(s) of Go which triggered the analyzer.

```go
for _, object := range objectsFound {

// ensure all objects are valuable and also ensure object's
if object.Type == models.ObjectValueless {
dbTx.Rollback()
services.Res(res).Error(400, "invalid_parameter", "objects: only valuable objects (object_value) can be merged")
return
}

// wallet id match the authorizing wallet id
if object.Wallet.ObjectID != authWalletID {
dbTx.Rollback()
services.Res(res).Error(401, "unauthorized", "objects: one or more objects belongs to a different wallet")
return
}

// ensure all objects are similar by their name / same issuer.
// this also ensures all objects have the same base currency
if checkObjName != object.Service.Identity.ObjectName {
dbTx.Rollback()
services.Res(res).Error(400, "invalid_parameter", "objects: only similar (by name) objects can be merged")
return
}

// updated total balance
totalBalance += object.Balance

// delete object
dbTx.Delete(&object)
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {Delete 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: f93870dd35c46c598e25f5f43d495b33b53d3934

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.