github-vet / github-vet/rangeloop-pointer-findings

itchio/wharf: taskgroup/taskgroup.go; 10 LoC

Open
#18,308 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [itchio/wharf](https://www.github.com/itchio/wharf) at [taskgroup/taskgroup.go](https://github.com/itchio/wharf/blob/e0beba7413124e6a5a2113df68b98d37f698c7d9/taskgroup/taskgroup.go#L22-L31)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable i used in defer or goroutine at line 26

[Click here to see the code in its original context.](https://github.com/itchio/wharf/blob/e0beba7413124e6a5a2113df68b98d37f698c7d9/taskgroup/taskgroup.go#L22-L31)

Click here to show the 10 line(s) of Go which triggered the analyzer.

```go
for i, task := range tasks {
go func(task Task) {
err := task()
if err != nil {
done <- errors.WithMessage(err, fmt.Sprintf("task %d", i+1))
return
}
done <- nil
}(task)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: e0beba7413124e6a5a2113df68b98d37f698c7d9

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with taskgroup/taskgroup.go lines 22-31 and the linked analyzer report, then inspect how the goroutine uses the range index. Done means determining whether the finding is a bug, mitigated, or desirable behavior and recording the appropriate reaction.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.