github-vet / github-vet/rangeloop-pointer-findings

linyuyizhipao/go-im: main.go; 14 LoC

Open
#18,300 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [linyuyizhipao/go-im](https://www.github.com/linyuyizhipao/go-im) at [main.go](https://github.com/linyuyizhipao/go-im/blob/37acbd06a9a56e554e570c35c67c366ef6b87392/main.go#L35-L48)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable msg used in defer or goroutine at line 39

[Click here to see the code in its original context.](https://github.com/linyuyizhipao/go-im/blob/37acbd06a9a56e554e570c35c67c366ef6b87392/main.go#L35-L48)

Click here to show the 14 line(s) of Go which triggered the analyzer.

```go
for msg := range easyim.MessageJsonByClient {
log.Info().Msgf("给客户端发送过来的消息:%s",msg)

go func(){
b, err := redis.Client.Do("lpush", "chat_test", msg).Bool()
if err != nil {
log.Error().Msg(fmt.Sprintf("lpush%s发生了错误,错误信息为:%s", msg, err.Error()))
}
if b != true {
log.Error().Msg(fmt.Sprintf("lpush发生失败了,错误信息为:%s", msg))
}
}()

}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 37acbd06a9a56e554e570c35c67c366ef6b87392

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.