github-vet / github-vet/rangeloop-pointer-findings

mindreframer/golang-devops-stuff: src/github.com/globocom/tsuru/app/actions.go; 6 LoC

Open
#18,255 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [mindreframer/golang-devops-stuff](https://www.github.com/mindreframer/golang-devops-stuff) at [src/github.com/globocom/tsuru/app/actions.go](https://github.com/mindreframer/golang-devops-stuff/blob/bb6c6c16ff0ae7892cd0ed0715b8a6b769052f9f/src/github.com/globocom/tsuru/app/actions.go#L340-L345)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to unit was used in a composite literal at line 341

[Click here to see the code in its original context.](https://github.com/mindreframer/golang-devops-stuff/blob/bb6c6c16ff0ae7892cd0ed0715b8a6b769052f9f/src/github.com/globocom/tsuru/app/actions.go#L340-L345)

Click here to show the 6 line(s) of Go which triggered the analyzer.

```go
for _, unit := range units {
err := app.BindUnit(&unit)
if err != nil {
return nil, err
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: bb6c6c16ff0ae7892cd0ed0715b8a6b769052f9f

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading src/github.com/globocom/tsuru/app/actions.go at lines 340-345 and review the analyzer message about the range-loop reference. Use the linked code context to decide whether the finding is a Bug, Mitigated, or Desirable Behavior, then leave the corresponding reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.