github-vet / github-vet/rangeloop-pointer-findings
patchwork-toolkit/patchwork: cmd/device-gateway/registration.go; 3 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [patchwork-toolkit/patchwork](https://www.github.com/patchwork-toolkit/patchwork) at [cmd/device-gateway/registration.go](https://github.com/patchwork-toolkit/patchwork/blob/829c1e12e9bff2fd679faabdccc1ce65c0a0922d/cmd/device-gateway/registration.go#L63-L65)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> function call at line 64 passes reference to r to third-party code
[Click here to see the code in its original context.](https://github.com/patchwork-toolkit/patchwork/blob/829c1e12e9bff2fd679faabdccc1ce65c0a0922d/cmd/device-gateway/registration.go#L63-L65)
Click here to show the 3 line(s) of Go which triggered the analyzer.
```go
for _, r := range devices {
catalog.RegisterDevice(client, &r)
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
The following graphviz dot graph describes paths through the callgraph that could lead to a function which passes a pointer to third-party code:
digraph G {
"(RegisterDevice, 2)" -> {"(Add, 1)";"(Update, 2)";}
"(Add, 1)" -> {}
"(Update, 2)" -> {}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 829c1e12e9bff2fd679faabdccc1ce65c0a0922d
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at cmd/device-gateway/registration.go lines 63-65 and inspect RegisterDevice, including its Add and Update paths. Check whether passing the range variable reference can cause incorrect behavior, then classify the finding as Bug, Mitigated, or Desirable Behavior by leaving the corresponding reaction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100