github-vet / github-vet/rangeloop-pointer-findings

l-dandelion/yi-ants-go: core/action/rpc/client.go; 21 LoC

Open
#18,212 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [l-dandelion/yi-ants-go](https://www.github.com/l-dandelion/yi-ants-go) at [core/action/rpc/client.go](https://github.com/l-dandelion/yi-ants-go/blob/3f4b1a0e617cb75ee8bbe14ce346302c2a5c6ab8/core/action/rpc/client.go#L292-L312)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable nodeInfo used in defer or goroutine at line 300

[Click here to see the code in its original context.](https://github.com/l-dandelion/yi-ants-go/blob/3f4b1a0e617cb75ee8bbe14ce346302c2a5c6ab8/core/action/rpc/client.go#L292-L312)

Click here to show the 21 line(s) of Go which triggered the analyzer.

```go
for _, nodeInfo := range nodeInfoList {
if !this.node.IsMe(nodeInfo.Name) {
go func() {
req := &action.RpcSpider{
Spider: csp,
}
req.NodeInfo = this.node.GetNodeInfo()
resp := &action.RpcError{}
err := this.connMap[nodeInfo.Name].Call("RpcServer.AddSpider", req, resp)
if err != nil {
yierr = constant.NewYiErrorf(constant.ERR_RPC_CALL,
"Add spider fail, Node: %s, spider: %v, ERROR: %s", nodeInfo.Name, spider, err)
log.Error(yierr)
}
if resp.Yierr != nil {
yierr = resp.Yierr
log.Errorf("Add spider fail, Node: %s, spider: %v, ERROR: %s", nodeInfo.Name, spider, yierr)
}
}()
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 3f4b1a0e617cb75ee8bbe14ce346302c2a5c6ab8

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.