github-vet / github-vet/rangeloop-pointer-findings

copernet/copernicus: logic/lmempool/ltxmempool.go; 19 LoC

Open
#18,202 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [copernet/copernicus](https://www.github.com/copernet/copernicus) at [logic/lmempool/ltxmempool.go](https://github.com/copernet/copernicus/blob/46353c3fb80dbfb0da4546a79351ef2d84ed809d/logic/lmempool/ltxmempool.go#L260-L278)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> function call at line 270 may store a reference to preout

[Click here to see the code in its original context.](https://github.com/copernet/copernicus/blob/46353c3fb80dbfb0da4546a79351ef2d84ed809d/logic/lmempool/ltxmempool.go#L260-L278)

Click here to show the 19 line(s) of Go which triggered the analyzer.

```go
for _, preout := range entry.Tx.GetAllPreviousOut() {
if entry, ok := allEntry[preout.Hash]; ok {
tx2 := entry.Tx
if !(tx2.GetOutsCount() > int(preout.Index) && !tx2.GetTxOut(int(preout.Index)).IsNull()) {
panic("the tx introduced input dose not exist, or the input amount is nil ")
}

fDependsWait = true
setParentCheck[tx2.GetHash()] = struct{}{}
} else {
if !view.HaveCoin(&preout) {
panic("the tx introduced input dose not exist mempool And UTXO set !!!")
}
}

if e := pool.HasSPentOutWithoutLock(&preout); e == nil {
panic("the introduced tx is not in mempool")
}
}

```

Click here to show extra information the analyzer produced.

```
The following graphviz dot graph describes paths through the callgraph that could lead to a function which writes a pointer argument:
digraph G {
"(HaveCoin, 1)" -> {"(NewCoinKey, 1)";}
"(NewCoinKey, 1)" -> {}
}

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 46353c3fb80dbfb0da4546a79351ef2d84ed809d

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.