the-rileyj/dsu-info-api: trojantimes/trojantimes.go; 28 LoC

Found a possible issue in [the-rileyj/dsu-info-api](https://www.github.com/the-rileyj/dsu-info-api) at [trojantimes/trojantimes.go](https://github.com/the-rileyj/dsu-info-api/blob/c7cb0bb4da550284c507cbd6e0b0194702567906/trojantimes/trojantimes.go#L493-L520)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/the-rileyj/dsu-info-api/blob/c7cb0bb4da550284c507cbd6e0b0194702567906/trojantimes/trojantimes.go#L493-L520)

Click here to show the 28 line(s) of Go which triggered the analyzer.

```go
for receivedTrojanTimesArticle := range getTrojanTimesArticlesChannel() {
err = db.First(&trojanTimesArticle, TrojanTimesArticle{URL: receivedTrojanTimesArticle.URL}).Error

if gorm.IsRecordNotFoundError(err) || (err == nil && trojanTimesArticle.LastModified != receivedTrojanTimesArticle.LastModified) {
// Establish the Article if it does not exist so that we can update it later
if gorm.IsRecordNotFoundError(err) {
db.Create(&receivedTrojanTimesArticle)
}

// send to request channel only after creating the article in the database;
// though extremely unlikely, if we swapped the order, the article could be
// updated before it is even created
articleRequestsChan <- receivedTrojanTimesArticle.URL
} else if err == nil {
// Check to see if any images have changed
for _, image := range receivedTrojanTimesArticle.Images {
err = db.First(&oldImage, ArticleImages{URL: receivedTrojanTimesArticle.URL}).Error

if gorm.IsRecordNotFoundError(err) {
db.Create(image)
} else if err == nil && image.LastModified != oldImage.LastModified {
db.Model(&oldImage).Updates(&image)
}
}
} else {
panic(err)
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {Create 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: c7cb0bb4da550284c507cbd6e0b0194702567906