github-vet / github-vet/rangeloop-pointer-findings

kubernetes-sigs/aws-load-balancer-controller: controllers/elbv2/eventhandlers/node.go; 29 LoC

Open
#18,107 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [kubernetes-sigs/aws-load-balancer-controller](https://www.github.com/kubernetes-sigs/aws-load-balancer-controller) at [controllers/elbv2/eventhandlers/node.go](https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/9a4e14094d75d679b6ac9f02a873191cad693e10/controllers/elbv2/eventhandlers/node.go#L77-L105)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

>

[Click here to see the code in its original context.](https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/9a4e14094d75d679b6ac9f02a873191cad693e10/controllers/elbv2/eventhandlers/node.go#L77-L105)

Click here to show the 29 line(s) of Go which triggered the analyzer.

```go
for _, tgb := range tgbList.Items {
if tgb.Spec.TargetType == nil || (*tgb.Spec.TargetType) != elbv2api.TargetTypeInstance {
continue
}

nodeSelector := backend.GetTrafficProxyNodeSelector(&tgb)

nodeOldIsTrafficProxy := false
nodeNewIsTrafficProxy := false
if nodeOld != nil {
nodeOldIsTrafficProxy = nodeOldIsReady && nodeSelector.Matches(labels.Set(nodeOld.Labels))
}
if nodeNew != nil {
nodeNewIsTrafficProxy = nodeNewIsReady && nodeSelector.Matches(labels.Set(nodeNew.Labels))
}

if nodeOldIsTrafficProxy != nodeNewIsTrafficProxy {
h.logger.V(1).Info("enqueue targetGroupBinding for node event",
"node", nodeKey,
"targetGroupBinding", k8s.NamespacedName(&tgb),
)
queue.Add(reconcile.Request{
NamespacedName: types.NamespacedName{
Namespace: tgb.Namespace,
Name: tgb.Name,
},
})
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.

root signature {NamespacedName 1} was not found in the callgraph; reference was passed directly to third-party code
```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 9a4e14094d75d679b6ac9f02a873191cad693e10

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in controllers/elbv2/eventhandlers/node.go at lines 77-105 and inspect how the range variable tgb is referenced and passed onward. Determine whether those pointer uses can produce incorrect behavior in the node event handler, then classify the analyzer finding as a bug, mitigated, or desirable behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.