github-vet / github-vet/rangeloop-pointer-findings

leopardslab/dunner: pkg/dunner/dunner.go; 31 LoC

Open
#18,074 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [leopardslab/dunner](https://www.github.com/leopardslab/dunner) at [pkg/dunner/dunner.go](https://github.com/leopardslab/dunner/blob/3017143faf209b074073e442092119a820ec5291/pkg/dunner/dunner.go#L63-L93)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> function call which takes a reference to stepDefinition at line 89 may start a goroutine

[Click here to see the code in its original context.](https://github.com/leopardslab/dunner/blob/3017143faf209b074073e442092119a820ec5291/pkg/dunner/dunner.go#L63-L93)

Click here to show the 31 line(s) of Go which triggered the analyzer.

```go
for _, stepDefinition := range configs.Tasks[taskName].Steps {
err := stepDefinition.ParseStepEnv()
if err != nil {
return err
}
if async {
wg.Add(1)
}
step := docker.Step{
Task: taskName,
Name: stepDefinition.Name,
Image: stepDefinition.Image,
Command: stepDefinition.Command,
Commands: stepDefinition.Commands,
Env: stepDefinition.Envs,
WorkDir: stepDefinition.Dir,
Follow: stepDefinition.Follow,
Args: stepDefinition.Args,
User: getDunnerUser(stepDefinition),
}

if err := PassGlobals(&step, configs, &stepDefinition, parentStep); err != nil {
log.Fatal(err)
}

if async {
go Process(configs, &step, &wg, args, &stepDefinition)
} else {
Process(configs, &step, &wg, args, &stepDefinition)
}
}

```

Click here to show extra information the analyzer produced.

```
The following graphviz dot graph describes paths through the callgraph that could lead to a function calling a goroutine:
digraph G {
"(ExecTask, 4)" -> {"(PassGlobals, 4)";}
"(PassGlobals, 4)" -> {}
"(Process, 5)" -> {"(ExecTask, 4)";}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 3017143faf209b074073e442092119a820ec5291

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.