github-vet / github-vet/rangeloop-pointer-findings
cjongseok/ntped: ntped.go; 10 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [cjongseok/ntped](https://www.github.com/cjongseok/ntped) at [ntped.go](https://github.com/cjongseok/ntped/blob/ce45fe09e9ad86d3a5663709ad8d972838fdce80/ntped.go#L66-L75)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable ntpAddr used in defer or goroutine at line 70
[Click here to see the code in its original context.](https://github.com/cjongseok/ntped/blob/ce45fe09e9ad86d3a5663709ad8d972838fdce80/ntped.go#L66-L75)
Click here to show the 10 line(s) of Go which triggered the analyzer.
```go
for _, ntpAddr := range ntpPool {
joinNtps.Add(1)
go func(out chan<- *ntp.Response) {
defer joinNtps.Done()
resp, err := ntp.QueryWithOptions(ntpAddr, options)
if err == nil {
out <- resp
}
}(respCh)
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: ce45fe09e9ad86d3a5663709ad8d972838fdce80
Contributor guide
No contributing guide indexed for this repository
Research direction
Review ntped.go lines 66-75, especially the goroutine using ntpAddr, and read the analyzer report in the issue. Determine whether the range-loop capture is a bug, mitigated, or desirable behavior, then leave the corresponding reaction on the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100