github-vet / github-vet/rangeloop-pointer-findings

kkkbird/qapp: app.go; 35 LoC

Open
#18,066 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [kkkbird/qapp](https://www.github.com/kkkbird/qapp) at [app.go](https://github.com/kkkbird/qapp/blob/509fb018ad18fa6659c7b985eec662e8a139872e/app.go#L267-L301)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable i used in defer or goroutine at line 271

[Click here to see the code in its original context.](https://github.com/kkkbird/qapp/blob/509fb018ad18fa6659c7b985eec662e8a139872e/app.go#L267-L301)

Click here to show the 35 line(s) of Go which triggered the analyzer.

```go
for i, s := range a.initStages {
cErr := make(chan error, 1)

go func() {
log.Infof("Init stage %d-%s", i, s.name)
a.initedStageIdx = i
cErr <- s.Run(ctx, a)
}()

select {
case err = <-cErr:
if err != nil {
panic("shoud not run to this line")
}
case err = <-a.initErrChan:
cancel()
if !strings.HasSuffix(err.Error(), ErrShowVersion.Error()) {
log.WithError(err).Errorf("!!Init err, exit in 1s")
}
select { // wait the init stage done or cleanTimeout duration
case <-cErr:
case <-time.After(time.Second):
}

return err
case <-ctx.Done():
log.Errorf("!!Init timeount, exit in 1s")
select { // wait the init stage done or cleanTimeout duration
case <-cErr:
case <-time.After(time.Second):
}

return ctx.Err()
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 509fb018ad18fa6659c7b985eec662e8a139872e

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with app.go lines 267-301 and inspect the initialization goroutine using the range variables i and s, alongside the surrounding initialization flow. Compare the analyzer warning with the project's intended behavior and run any available Go tests or checks. Done means determining whether this is a real bug or desirable behavior and recording the appropriate classification.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.