github-vet / github-vet/rangeloop-pointer-findings

hoysoft/JexGO: tasks.go; 12 LoC

Open
#18,058 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [hoysoft/JexGO](https://www.github.com/hoysoft/JexGO) at [tasks.go](https://github.com/hoysoft/JexGO/blob/61522cea2b41ba3707686420b06856121130e3f9/tasks.go#L26-L37)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable k used in defer or goroutine at line 31

[Click here to see the code in its original context.](https://github.com/hoysoft/JexGO/blob/61522cea2b41ba3707686420b06856121130e3f9/tasks.go#L26-L37)

Click here to show the 12 line(s) of Go which triggered the analyzer.

```go
for k,v:=range t.tasks{
if t.breaktag {break}

maxGoroutine <- 1
go func(r func() error) {
fmt.Println("start task:",k)
r()
fmt.Println("finish task:",k)
<-maxGoroutine
}(v)
delete(t.tasks,k)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 61522cea2b41ba3707686420b06856121130e3f9

Contributor guide

No contributing guide indexed for this repository

Research direction

Read tasks.go lines 26-37 and inspect the reported use of the range-loop variable k inside the goroutine. Verify the analyzer finding in context, then classify it as Bug, Mitigated, or Desirable Behavior by leaving the requested reaction on the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.