github-vet / github-vet/rangeloop-pointer-findings
twmb/franz-go: pkg/kgo/client.go; 23 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [twmb/franz-go](https://www.github.com/twmb/franz-go) at [pkg/kgo/client.go](https://github.com/twmb/franz-go/blob/303186a3a720c45a2e71333a6310b06ff4aa097d/pkg/kgo/client.go#L786-L808)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> range-loop variable name used in defer or goroutine at line 792
[Click here to see the code in its original context.](https://github.com/twmb/franz-go/blob/303186a3a720c45a2e71333a6310b06ff4aa097d/pkg/kgo/client.go#L786-L808)
Click here to show the 23 line(s) of Go which triggered the analyzer.
```go
for _, name := range names {
myName := name
wg.Add(1)
go func() {
defer wg.Done()
coordinator, err := cl.loadCoordinator(reload, ctx, coordinatorKey{
name: myName,
typ: typ,
})
mu.Lock()
defer mu.Unlock()
if err != nil {
if errQuit != nil {
errQuit = err
cancel()
}
return
}
m[myName] = coordinator
}()
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 303186a3a720c45a2e71333a6310b06ff4aa097d
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.