github-vet / github-vet/rangeloop-pointer-findings

veryrich/kafkaWeb: utils/consumer.go; 6 LoC

Open
#18,016 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [veryrich/kafkaWeb](https://www.github.com/veryrich/kafkaWeb) at [utils/consumer.go](https://github.com/veryrich/kafkaWeb/blob/e55b4eabf761e0326e4163bad91b2ff876b0c36f/utils/consumer.go#L46-L51)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable partition used in defer or goroutine at line 49

[Click here to see the code in its original context.](https://github.com/veryrich/kafkaWeb/blob/e55b4eabf761e0326e4163bad91b2ff876b0c36f/utils/consumer.go#L46-L51)

Click here to show the 6 line(s) of Go which triggered the analyzer.

```go
for partition := range partitions {
wg.Add(1)
go func() {
consumePartition(consumer, int32(partition), times, topic, ch, &wg)
}()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: e55b4eabf761e0326e4163bad91b2ff876b0c36f

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with utils/consumer.go lines 46-51 at commit e55b4eabf761e0326e4163bad91b2ff876b0c36f and read the surrounding consumer code. Compare the range-loop capture with the analyzer guidance in the linked repository, then classify the finding as Bug, Mitigated, or Desirable Behavior by leaving the corresponding reaction. Done means one classification reaction accurately reflects the instance.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kafka
Domain
backend, stream-processing
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.