github-vet / github-vet/rangeloop-pointer-findings
atenart/bubbles: httpserver/account.go; 10 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [atenart/bubbles](https://www.github.com/atenart/bubbles) at [httpserver/account.go](https://github.com/atenart/bubbles/blob/f68337784251e0426196f36024da15ab1bc7b844/httpserver/account.go#L185-L194)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to h was used in a composite literal at line 190
[Click here to see the code in its original context.](https://github.com/atenart/bubbles/blob/f68337784251e0426196f36024da15ab1bc7b844/httpserver/account.go#L185-L194)
Click here to show the 10 line(s) of Go which triggered the analyzer.
```go
for _, h := range xml.Hops {
ingredient := &db.Ingredient{
Name: h.Name,
UserId: user.Id,
Type: "hop",
XML: &h,
}
s.db.AddIngredient(ingredient)
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: f68337784251e0426196f36024da15ab1bc7b844
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with httpserver/account.go lines 185-194 and read the analyzer report about the reference to h in the composite literal. Trace how the resulting db.Ingredient is used, then determine whether the reported behavior is a bug, mitigated, or desirable. There are no tests or expected outcomes named in the issue, so completion depends on establishing the classification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100