github-vet / github-vet/rangeloop-pointer-findings
atenart/bubbles: httpserver/account.go; 12 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [atenart/bubbles](https://www.github.com/atenart/bubbles) at [httpserver/account.go](https://github.com/atenart/bubbles/blob/f68337784251e0426196f36024da15ab1bc7b844/httpserver/account.go#L159-L170)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to r was used in a composite literal at line 163
[Click here to see the code in its original context.](https://github.com/atenart/bubbles/blob/f68337784251e0426196f36024da15ab1bc7b844/httpserver/account.go#L159-L170)
Click here to show the 12 line(s) of Go which triggered the analyzer.
```go
for _, r := range xml.Recipes {
recipe := &db.Recipe{
Name: r.Name,
UserId: user.Id,
XML: &r,
}
if _, err := s.db.AddRecipe(recipe); err != nil {
http.Error(w, err.Error(), 500)
return
}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: f68337784251e0426196f36024da15ab1bc7b844
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with httpserver/account.go lines 159-170 and the linked commit context. Review the analyzer's range-loop-pointer finding and determine whether the reference used in the db.Recipe literal can produce incorrect behavior. Done means recording the appropriate Bug, Mitigated, or Desirable Behavior classification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100