github-vet / github-vet/rangeloop-pointer-findings

sahib/brig: cmd/suggest.go; 5 LoC

Open
#17,991 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [sahib/brig](https://www.github.com/sahib/brig) at [cmd/suggest.go](https://github.com/sahib/brig/blob/cd3ba4a9f7b3eb55019e43b54d8ec6863537201a/cmd/suggest.go#L51-L55)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to subCmd is reassigned at line 53

[Click here to see the code in its original context.](https://github.com/sahib/brig/blob/cd3ba4a9f7b3eb55019e43b54d8ec6863537201a/cmd/suggest.go#L51-L55)

Click here to show the 5 line(s) of Go which triggered the analyzer.

```go
for _, subCmd := range cmd.Subcommands {
if subCmd.Name == args[0] {
cmd = &subCmd
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: cd3ba4a9f7b3eb55019e43b54d8ec6863537201a

Contributor guide

No contributing guide indexed for this repository

Research direction

Read cmd/suggest.go around lines 51-55 and inspect how the matching subcommand is selected and used afterward. Determine whether the analyzer's reported reassignment is a real bug or intended behavior, then verify the appropriate Bug, Mitigated, or Desirable Behavior classification against the surrounding command logic.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.