github-vet / github-vet/rangeloop-pointer-findings

tleyden/keynuker: github_user_aggregator.go; 5 LoC

Open
#17,988 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [tleyden/keynuker](https://www.github.com/tleyden/keynuker) at [github_user_aggregator.go](https://github.com/tleyden/keynuker/blob/b027d789208844f958a2c4945cc39f06f3291b1a/github_user_aggregator.go#L236-L240)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to githubUserLogin is reassigned at line 238

[Click here to see the code in its original context.](https://github.com/tleyden/keynuker/blob/b027d789208844f958a2c4945cc39f06f3291b1a/github_user_aggregator.go#L236-L240)

Click here to show the 5 line(s) of Go which triggered the analyzer.

```go
for _, githubUserLogin := range p.GithubUsers {
resultUser := &github.User{}
resultUser.Login = &githubUserLogin
resultUsers = append(resultUsers, resultUser)
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: b027d789208844f958a2c4945cc39f06f3291b1a

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with github_user_aggregator.go at lines 236-240 and read the linked rangeclosure-findings classification descriptions. Check the surrounding code and analyzer report, then leave the appropriate reaction; done means the finding is classified as Bug, Mitigated, or Desirable Behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.