github-vet / github-vet/rangeloop-pointer-findings
honcao/azurestackcloudprovider: src/k8s.io/kubernetes/pkg/controller/node/controller_utils.go; 19 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [honcao/azurestackcloudprovider](https://www.github.com/honcao/azurestackcloudprovider) at [src/k8s.io/kubernetes/pkg/controller/node/controller_utils.go](https://github.com/honcao/azurestackcloudprovider/blob/d1a86d9aef47f551d271b8f9d704b46f58ed5660/src/k8s.io/kubernetes/pkg/controller/node/controller_utils.go#L211-L229)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/honcao/azurestackcloudprovider/blob/d1a86d9aef47f551d271b8f9d704b46f58ed5660/src/k8s.io/kubernetes/pkg/controller/node/controller_utils.go#L211-L229)
Click here to show the 19 line(s) of Go which triggered the analyzer.
```go
for _, pod := range pods.Items {
// Defensive check, also needed for tests.
if pod.Spec.NodeName != nodeName {
continue
}
for i, cond := range pod.Status.Conditions {
if cond.Type == v1.PodReady {
pod.Status.Conditions[i].Status = v1.ConditionFalse
glog.V(2).Infof("Updating ready status of pod %v to false", pod.Name)
_, err := kubeClient.Core().Pods(pod.Namespace).UpdateStatus(&pod)
if err != nil {
glog.Warningf("Failed to update status for pod %q: %v", format.Pod(&pod), err)
errMsg = append(errMsg, fmt.Sprintf("%v", err))
}
break
}
}
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {Pod 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: d1a86d9aef47f551d271b8f9d704b46f58ed5660
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.