github-vet / github-vet/rangeloop-pointer-findings
lpetrea/jenkins-x: pkg/apis/jenkins.io/v1/zz_generated.deepcopy.go; 11 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [lpetrea/jenkins-x](https://www.github.com/lpetrea/jenkins-x) at [pkg/apis/jenkins.io/v1/zz_generated.deepcopy.go](https://github.com/lpetrea/jenkins-x/blob/687267595ef61c88f21fa935c542ccf2f7ec7d5a/pkg/apis/jenkins.io/v1/zz_generated.deepcopy.go#L2460-L2470)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> reference to val is reassigned at line 2465
[Click here to see the code in its original context.](https://github.com/lpetrea/jenkins-x/blob/687267595ef61c88f21fa935c542ccf2f7ec7d5a/pkg/apis/jenkins.io/v1/zz_generated.deepcopy.go#L2460-L2470)
Click here to show the 11 line(s) of Go which triggered the analyzer.
```go
for key, val := range *in {
var outVal *ProtectionPolicy
if val == nil {
(*out)[key] = nil
} else {
in, out := &val, &outVal
*out = new(ProtectionPolicy)
(*in).DeepCopyInto(*out)
}
(*out)[key] = outVal
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 687267595ef61c88f21fa935c542ccf2f7ec7d5a
Contributor guide
No contributing guide indexed for this repository
Research direction
Inspect pkg/apis/jenkins.io/v1/zz_generated.deepcopy.go at commit 687267595ef61c88f21fa935c542ccf2f7ec7d5a, especially the reported range loop around lines 2460-2470. Determine whether the reassigned range variable can affect the deepcopy result, then use the requested reaction to classify it as a bug, mitigated, or desirable behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 15/100