lpetrea/jenkins-x: pkg/kube/activity.go; 12 LoC

Found a possible issue in [lpetrea/jenkins-x](https://www.github.com/lpetrea/jenkins-x) at [pkg/kube/activity.go](https://github.com/lpetrea/jenkins-x/blob/687267595ef61c88f21fa935c542ccf2f7ec7d5a/pkg/kube/activity.go#L286-L297)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> function call at line 293 passes reference to v to third-party code

[Click here to see the code in its original context.](https://github.com/lpetrea/jenkins-x/blob/687267595ef61c88f21fa935c542ccf2f7ec7d5a/pkg/kube/activity.go#L286-L297)

Click here to show the 12 line(s) of Go which triggered the analyzer.

```go
for _, v := range activities.Items {
if v.Spec.BatchPipelineActivity.BatchBuildNumber != "" {
if buildNumber, err := strconv.Atoi(v.Spec.Build); err == nil {
//Check if it's the previous build, then we can update the PRs and the batch build
if previousBuildNumber == buildNumber {
log.Infof("Found an earlier PipelineActivity for %s and equal lastCommitSha with batch information", labels[v1.LabelBranch])
currentActivity.Spec.BatchPipelineActivity.BatchBuildNumber = v.Spec.BatchPipelineActivity.BatchBuildNumber
return updateBatchBuildComprisingPRs(activitiesClient, currentActivity, v.Spec.BatchPipelineActivity.BatchBuildNumber, &v)
}
}
}
}

```

Click here to show extra information the analyzer produced.

```
No path was found through the callgraph that could lead to a function which writes a pointer argument.

The following graphviz dot graph describes paths through the callgraph that could lead to a function which passes a pointer to third-party code:
digraph G {
"(Update, 1)" -> {}
"(updateBatchBuildComprisingPRs, 4)" -> {"(Update, 1)";}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 687267595ef61c88f21fa935c542ccf2f7ec7d5a

Read pkg/kube/activity.go at lines 286-297, then inspect updateBatchBuildComprisingPRs and the Update call shown in the analyzer output. Determine whether passing the range-loop variable by reference can cause an unsafe or unintended update, and classify the finding as Bug, Mitigated, or Desirable Behavior using the linked project guidance.

Written by the indexing model from the issue text.