github-vet / github-vet/rangeloop-pointer-findings

cr0sh/encore: raknet/session.go; 19 LoC

Open
#17,944 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [cr0sh/encore](https://www.github.com/cr0sh/encore) at [raknet/session.go](https://github.com/cr0sh/encore/blob/e3d6309d02103bb05bc78719516c45870aa47818/raknet/session.go#L405-L423)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to ep was used in a composite literal at line 411

[Click here to see the code in its original context.](https://github.com/cr0sh/encore/blob/e3d6309d02103bb05bc78719516c45870aa47818/raknet/session.go#L405-L423)

Click here to show the 19 line(s) of Go which triggered the analyzer.

```go
for _, ep := range dp.Packets {
var ptrs []unsafe.Pointer
if ep.Reliability >= 2 && ep.Reliability != 5 {
ptrs = sess.encapsulatedPacketWindow.Put(uint64(ep.MessageIndex), unsafe.Pointer(&ep))

} else {
ptrs = []unsafe.Pointer{unsafe.Pointer(&ep)}
}
for _, ptr := range ptrs {
ep := (*EncapsulatedPacket)(ptr)
if ep.IsSplit {
if b := sess.putSplit(*ep); b != nil {
bs = append(bs, b)
}
} else {
bs = append(bs, ep.Payload)
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: e3d6309d02103bb05bc78719516c45870aa47818

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.