github-vet / github-vet/rangeloop-pointer-findings

Nitro/envoy-docker-shim: cmd/envoy-docker-shim/docker.go; 8 LoC

Open
#17,938 0 comments 0 reactions 0 assignees View on GitHub
fresh tiny
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [Nitro/envoy-docker-shim](https://www.github.com/Nitro/envoy-docker-shim) at [cmd/envoy-docker-shim/docker.go](https://github.com/Nitro/envoy-docker-shim/blob/fd521c78b937b551eef4cc849776fbf42d859937/cmd/envoy-docker-shim/docker.go#L71-L78)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> reference to container is reassigned at line 74

[Click here to see the code in its original context.](https://github.com/Nitro/envoy-docker-shim/blob/fd521c78b937b551eef4cc849776fbf42d859937/cmd/envoy-docker-shim/docker.go#L71-L78)

Click here to show the 8 line(s) of Go which triggered the analyzer.

```go
for _, container := range containers {
for _, p := range container.Ports {
if p.PublicPort == port64 {
foundContainer = &container
break OUTER
}
}
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: fd521c78b937b551eef4cc849776fbf42d859937

Contributor guide

No contributing guide indexed for this repository

Research direction

Read cmd/envoy-docker-shim/docker.go at the linked lines and inspect the surrounding range-loop context. Review the linked classification descriptions, then react to the issue as Bug, Mitigated, or Desirable Behavior; done means recording the appropriate classification.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.