github-vet / github-vet/rangeloop-pointer-findings
dddpaul/vscalebot: pkg/telegram/bot.go; 3 LoC
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- PR metrics pending
Description
Found a possible issue in [dddpaul/vscalebot](https://www.github.com/dddpaul/vscalebot) at [pkg/telegram/bot.go](https://github.com/dddpaul/vscalebot/blob/894299d912f1fa48943171f607fb675cf1b979be/pkg/telegram/bot.go#L126-L128)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
> function call at line 127 passes reference to c to third-party code
[Click here to see the code in its original context.](https://github.com/dddpaul/vscalebot/blob/894299d912f1fa48943171f607fb675cf1b979be/pkg/telegram/bot.go#L126-L128)
Click here to show the 3 line(s) of Go which triggered the analyzer.
```go
for _, c := range chats {
b.bot.Send(&c, fmt.Sprintf("%s balance is %.2f roubles", name, balance))
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
The following graphviz dot graph describes paths through the callgraph that could lead to a function which passes a pointer to third-party code:
digraph G {
"(Send, 2)" -> {}
}
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 894299d912f1fa48943171f607fb675cf1b979be
Contributor guide
No contributing guide indexed for this repository
Research direction
Read pkg/telegram/bot.go at lines 126-128 in the linked vscalebot commit, then inspect the Send call and the surrounding range loop. Determine whether passing the loop variable reference is a bug, mitigated, or desirable behavior, and record that classification on the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100