github-vet / github-vet/rangeloop-pointer-findings

sxfworks/go-mcached: server/server.go; 13 LoC

Open
#17,926 0 comments 0 reactions 0 assignees View on GitHub
fresh small
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
PR metrics pending

Description

Found a possible issue in [sxfworks/go-mcached](https://www.github.com/sxfworks/go-mcached) at [server/server.go](https://github.com/sxfworks/go-mcached/blob/9884130b6b66614dc587926cd1e61e699639fb54/server/server.go#L300-L312)

Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.

> range-loop variable isLeader used in defer or goroutine at line 306

[Click here to see the code in its original context.](https://github.com/sxfworks/go-mcached/blob/9884130b6b66614dc587926cd1e61e699639fb54/server/server.go#L300-L312)

Click here to show the 13 line(s) of Go which triggered the analyzer.

```go
for isLeader := range s.raft.LeaderCh() {
wg := new(sync.WaitGroup)
wg.Add(len(funcs))
for _, f := range funcs {
go func(f func(isLeader bool) error) {
defer wg.Done()
if err := f(isLeader); err != nil {
s.Logger.Printf("[WARN] server: error while executing function when leader changed: %v", err)
}
}(f)
}
wg.Wait()
}

```

Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.

commit ID: 9884130b6b66614dc587926cd1e61e699639fb54

Contributor guide

No contributing guide indexed for this repository

Research direction

Read server/server.go at lines 300-312 and inspect how the range-loop value is used by the goroutines, then compare that behavior with the analyzer's warning. When the finding is understood, react with Bug, Mitigated, or Desirable Behavior; completion is the selected classification.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.